[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1650348310-18553-1-git-send-email-baihaowen@meizu.com>
Date: Tue, 19 Apr 2022 14:05:10 +0800
From: Haowen Bai <baihaowen@...zu.com>
To: <svens@...ux.ibm.com>
CC: <agordeev@...ux.ibm.com>, <baihaowen@...zu.com>,
<borntraeger@...ux.ibm.com>, <gor@...ux.ibm.com>,
<hca@...ux.ibm.com>, <hoeppner@...ux.ibm.com>,
<linux-kernel@...r.kernel.org>, <linux-s390@...r.kernel.org>,
<sth@...ux.ibm.com>
Subject: [PATCH V2] s390/dasd: Use kzalloc instead of kmalloc/memset
Use kzalloc rather than duplicating its implementation, which
makes code simple and easy to understand.
Signed-off-by: Haowen Bai <baihaowen@...zu.com>
---
V1->V2: also remove the isglobal assigment above, so the whole else block
could go away
drivers/s390/block/dasd_eckd.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index 8410a25a65c1..6b70f9dfff02 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -1480,7 +1480,7 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
{
struct pe_handler_work_data *data;
- data = kmalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
+ data = kzalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
if (!data) {
if (mutex_trylock(&dasd_pe_handler_mutex)) {
data = pe_handler_worker;
@@ -1488,9 +1488,6 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
} else {
return -ENOMEM;
}
- } else {
- memset(data, 0, sizeof(*data));
- data->isglobal = 0;
}
INIT_WORK(&data->worker, do_pe_handler_work);
dasd_get_device(device);
--
2.7.4
Powered by blists - more mailing lists