[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220419063057.gv262tcgq3kvlqc7@soft-dev3-1.localhost>
Date: Tue, 19 Apr 2022 08:30:57 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<UNGLinuxDriver@...rochip.com>, <davem@...emloft.net>,
<pabeni@...hat.com>
Subject: Re: [PATCH net] net: lan966x: Make sure to release ptp interrupt
The 04/15/2022 21:01, Jakub Kicinski wrote:
>
> On Wed, 13 Apr 2022 21:57:16 +0200 Horatiu Vultur wrote:
> > When the lan966x driver is removed make sure to remove also the ptp_irq
> > IRQ.
>
> I presume it's because you want to disable the IRQ so it doesn't fire
> during / after remove? Would be good to have such justifications
> spelled out in the commit message in the future!
Sorry about this. I will improve the commit messages in the future.
>
> > Fixes: e85a96e48e3309 ("net: lan966x: Add support for ptp interrupts")
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
--
/Horatiu
Powered by blists - more mailing lists