lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Apr 2022 09:22:21 +0200 From: Paolo Abeni <pabeni@...hat.com> To: Christophe Leroy <christophe.leroy@...roup.eu>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Douglas Miller <dougmill@...ux.ibm.com>, Dany Madden <drt@...ux.ibm.com>, Sukadev Bhattiprolu <sukadev@...ux.ibm.com>, Thomas Falcon <tlfalcon@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Ishizaki Kou <kou.ishizaki@...hiba.co.jp>, Geoff Levand <geoff@...radead.org> Cc: linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, netdev@...r.kernel.org Subject: Re: [PATCH net-next v2] net: ethernet: Prepare cleanup of powerpc's asm/prom.h Hello, Sorry for the late reply. On Fri, 2022-04-15 at 10:39 +0200, Christophe Leroy wrote: > powerpc's asm/prom.h brings some headers that it doesn't > need itself. It's probably my fault, but I really can't parse the above. Could you please re-phrase? > > In order to clean it up in a further step, first clean all > files that include asm/prom.h > > Some files don't need asm/prom.h at all. For those ones, > just remove inclusion of asm/prom.h > > Some files don't need any of the items provided by asm/prom.h, > but need some of the headers included by asm/prom.h. For those > ones, add the needed headers that are brought by asm/prom.h at > the moment, then remove asm/prom.h Do you mean a follow-up patch is needed to drop the asm/prom.h include from such files, even if that include could be dropped now without any fourther change? If so, I suggest v3 should additionally drop the asm/prom.h include where possible. Thanks! Paolo
Powered by blists - more mailing lists