[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAN8YU5PeDd8BQYHQVAzfkni_v55UjaJsRJ4ATs0FAVFt1KKX=g@mail.gmail.com>
Date: Tue, 19 Apr 2022 09:48:13 +0200
From: Andrea Merello <andrea.merello@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
linux-iio <linux-iio@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
devicetree <devicetree@...r.kernel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Rob Herring <robh+dt@...nel.org>,
Matt Ranostay <matt.ranostay@...sulko.com>,
Alexandru Ardelean <ardeleanalex@...il.com>,
jmondi <jacopo@...ndi.org>,
Andrea Merello <andrea.merello@....it>
Subject: Re: [v4 12/14] iio: imu: add BNO055 serdev driver
Il giorno sab 16 apr 2022 alle ore 10:45 Andy Shevchenko
<andy.shevchenko@...il.com> ha scritto:
>
> On Fri, Apr 15, 2022 at 7:40 PM Jonathan Cameron <jic23@...nel.org> wrote:
> > On Fri, 15 Apr 2022 15:00:03 +0200
> > Andrea Merello <andrea.merello@...il.com> wrote:
>
> ...
>
> > > +CFLAGS_bno055_ser.o := -I$(src)
> >
> > Via a bit of grepping I can see other instances of this pattern which point out
> > that it's to do with allowing the tracing framework to see trace.h.
> > Perhaps a similar comment here would be good (if nothing else I doubt I'll
> > remember why this magic is here in a few years time!)
>
> Can be done better way, see dwc3 or drivers/base/ trace point implementations.
May you elaborate, please? It appears that both dwc3 and driver/base
use this same trick of tweaking the CFLAGS in the Makefile in order to
fix the header file thing. What I see is different is that they both
use an (almost empty) trace.c file. Is this what you are suggesting?
>
> --
> With Best Regards,
> Andy Shevchenko
Powered by blists - more mailing lists