linux-kernel - RE: [PATCH] extcon: ptn5150: add usb role class support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB4333585DED292C3AC920B21E89F29@VI1PR04MB4333.eurprd04.prod.outlook.com>
Date:   Tue, 19 Apr 2022 07:53:50 +0000
From:   Jun Li <jun.li@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
        "cw00.choi@...sung.com" <cw00.choi@...sung.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Frank Li <frank.li@....com>, Xu Yang <xu.yang_2@....com>
Subject: RE: [PATCH] extcon: ptn5150: add usb role class support



> -----Original Message-----
> From: Jun Li
> Sent: Wednesday, April 6, 2022 7:49 PM
> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>;
> myungjoo.ham@...sung.com; cw00.choi@...sung.com
> Cc: linux-kernel@...r.kernel.org; Frank Li <frank.li@....com>; Xu Yang
> <xu.yang_2@....com>
> Subject: RE: [PATCH] extcon: ptn5150: add usb role class support
> 
> 
> 
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Sent: Wednesday, April 6, 2022 6:16 PM
> > To: Jun Li <jun.li@....com>; myungjoo.ham@...sung.com;
> > cw00.choi@...sung.com
> > Cc: linux-kernel@...r.kernel.org; Frank Li <frank.li@....com>; Xu Yang
> > <xu.yang_2@....com>
> > Subject: Re: [PATCH] extcon: ptn5150: add usb role class support
> >
> > On 06/04/2022 11:42, Li Jun wrote:
> > > Add support of usb role class consumer to do role switch.
> >
> > Please mention also why you are doing this.
> 
> Will improve in v2.
> 
> >
> > >
> > > Signed-off-by: Li Jun <jun.li@....com>
> > > ---
> > >  drivers/extcon/Kconfig          |  1 +
> > >  drivers/extcon/extcon-ptn5150.c | 39
> > > +++++++++++++++++++++++++++++++++
> > >  2 files changed, 40 insertions(+)
> > >
> > > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig index
> > > 0d42e49105dd..9828ade787a8 100644
> > > --- a/drivers/extcon/Kconfig
> > > +++ b/drivers/extcon/Kconfig
> > > @@ -132,6 +132,7 @@ config EXTCON_PTN5150
> > >  	tristate "NXP PTN5150 CC LOGIC USB EXTCON support"
> > >  	depends on I2C && (GPIOLIB || COMPILE_TEST)
> > >  	select REGMAP_I2C
> > > +	select USB_ROLE_SWITCH
> >
> > You do not need to select it. Driver will work without role switch,
> > won't it? If it works, then probably it should be just imply.
> 
> Okay, usb role class provider should enable this for me, will drop it.

A second check on this and I think I still need this, there
maybe some usb controller driver without usb role switch
+ ptn5150 via extcon, so no need USB_ROLE_SWITCH, I need
select it to avoid build break.

Li Jun