linux-kernel - RE: [PATCH 19/20] tty: n_gsm: fix wrong behavior of gsm_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 19 Apr 2022 07:58:50 +0000
From:   "Starke, Daniel" <daniel.starke@...mens.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 19/20] tty: n_gsm: fix wrong behavior of
 gsm_carrier_raised() on debug

> > From: Daniel Starke <daniel.starke@...mens.com>
> > 
> > gsm_carrier_raised() returns always 1 if the kernel module parameter 
> > 'debug' has its second least significant bit set. This changes the 
> > behavior of the module instead of just adding some debug output.
> > Remove this 'debug' gated early out to avoid debug settings from 
> > changing the program flow.
> > 
> > Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
> > Cc: stable@...r.kernel.org
> 
> Why is this relevant for stable backporting?  It's a debugging feature
> only, and you are changing how it previously worked :(

You are right. This was a mistake on my side. Please ignore this commit
completely.

Best regards,
Daniel Starke