linux-kernel - RE: [PATCH bpf-next 07/11] samples: bpf: fix uin64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9465da05497746b3b70d7c841a585d5b@AcuMS.aculab.com>
Date:   Tue, 19 Apr 2022 08:07:50 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Alexander Lobakin' <alobakin@...me>, Song Liu <song@...nel.org>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        "Arnaldo Carvalho de Melo" <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "Alexander Shishkin" <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Jesper Dangaard Brouer" <hawk@...nel.org>,
        Björn Töpel <bjorn@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        "Jonathan Lemon" <jonathan.lemon@...il.com>,
        Nathan Chancellor <nathan@...nel.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        Dmitrii Dolgov <9erthalion6@...il.com>,
        Quentin Monnet <quentin@...valent.com>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        "Chenbo Feng" <fengc@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Thomas Graf <tgraf@...g.ch>,
        Ong Boon Leong <boon.leong.ong@...el.com>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
        "open list" <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>
Subject: RE: [PATCH bpf-next 07/11] samples: bpf: fix uin64_t format literals

From: Alexander Lobakin
> Sent: 16 April 2022 18:55
> To: Song Liu <song@...nel.org>
> 
> From: Song Liu <song@...nel.org>
> Date: Fri, 15 Apr 2022 16:52:13 -0700
> 
> > On Thu, Apr 14, 2022 at 3:46 PM Alexander Lobakin <alobakin@...me> wrote:
> > >
> > > There's a couple places where uin64_t is being passed as an %ld
> > > format argument, which is incorrect (should be %lld). Fix them.
> >
> > This will cause some warning on some 64-bit compiler, no?
> 
> Oh wait, I accidentially mentioned %ld and %lld although in fact I
> changed %lu to %llu. So there won't be any compiler warnings. I'll
> fix the commit message in v2.

That won't make any difference.
The correct way to print uint64_t is using PRIu64.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)