linux-kernel - Re: [PATCH v2 2/2] extcon: ptn5150: Add usb role class support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e569119-32e9-6549-d805-85f44fc5660e@linaro.org>
Date:   Tue, 19 Apr 2022 10:35:09 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Li Jun <jun.li@....com>, myungjoo.ham@...sung.com,
        cw00.choi@...sung.com
Cc:     linux-kernel@...r.kernel.org, frank.li@....com, xu.yang_2@....com
Subject: Re: [PATCH v2 2/2] extcon: ptn5150: Add usb role class support

On 19/04/2022 09:43, Li Jun wrote:
> Some usb controller drivers may not support extcon but use
> usb role class as it's the preferred approach, so to support
> usb dual role switch with usb role class, add usb role class
> consumer support.
> 
> Signed-off-by: Li Jun <jun.li@....com>
> ---
> change for v2:
> - Add one patch to sync queue work before driver remove.
> - improve git commit log
> - use a variable of usb_role to set target role in
>   ptn5150_check_state() to simplify code.
> - use dev_err_probe for usb_role_switch_get() return value.
> 
>  drivers/extcon/Kconfig          |  1 +
>  drivers/extcon/extcon-ptn5150.c | 25 +++++++++++++++++++++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index c69d40ae5619..f3352a81ee7c 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -130,6 +130,7 @@ config EXTCON_PTN5150
>  	tristate "NXP PTN5150 CC LOGIC USB EXTCON support"
>  	depends on I2C && (GPIOLIB || COMPILE_TEST)
>  	select REGMAP_I2C
> +	select USB_ROLE_SWITCH

This is still being discussed. Rest looks good.

Best regards,
Krzysztof