linux-kernel - Re: [PATCH] net: cosa: fix error check return value of register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220419083228.GA25641@fi.muni.cz>
Date:   Tue, 19 Apr 2022 10:32:28 +0200
From:   Jan Kasprzak <kas@...muni.cz>
To:     cgel.zte@...il.com
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lv Ruyi <lv.ruyi@....com.cn>, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] net: cosa: fix error check return value of
 register_chrdev()

Acked-By: Jan "Yenya" Kasprzak <kas@...muni.cz>

Thanks!

-Yenya

cgel.zte@...il.com wrote:
: From: Lv Ruyi <lv.ruyi@....com.cn>
: 
: If major equal 0, register_chrdev() returns error code when it fails.
: This function dynamically allocate a major and return its number on
: success, so we should use "< 0" to check it instead of "!".
: 
: Reported-by: Zeal Robot <zealci@....com.cn>
: Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>
: ---
:  drivers/net/wan/cosa.c | 2 +-
:  1 file changed, 1 insertion(+), 1 deletion(-)
: 
: diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
: index 23d2954d9747..1e5672019922 100644
: --- a/drivers/net/wan/cosa.c
: +++ b/drivers/net/wan/cosa.c
: @@ -349,7 +349,7 @@ static int __init cosa_init(void)
:  		}
:  	} else {
:  		cosa_major = register_chrdev(0, "cosa", &cosa_fops);
: -		if (!cosa_major) {
: +		if (cosa_major < 0) {
:  			pr_warn("unable to register chardev\n");
:  			err = -EIO;
:  			goto out;
: -- 
: 2.25.1
: 

-- 
| Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> |
| http://www.fi.muni.cz/~kas/                         GPG: 4096R/A45477D5 |
    We all agree on the necessity of compromise. We just can't agree on
    when it's necessary to compromise.                     --Larry Wall