linux-kernel - RE: [PATCH 2/2] staging: vt6655: Replace VNSvInPortB with ioread8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Apr 2022 08:57:59 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Philipp Hortmann' <philipp.g.hortmann@...il.com>,
        Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] staging: vt6655: Replace VNSvInPortB with ioread8

From: Philipp Hortmann
> Sent: 16 April 2022 09:01
> 
> Replace macro VNSvInPortB with ioread8. Avoid cast of the return
> value is possible with one exception.

Unless the hardware might be using PCI io space (which I doubt)
shouldn't it be using readb() not ioread8() ?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)