linux-kernel - RE: [PATCH net-next v8 2/2] net: ethernet: Add driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e784ab5356aa4b6e93765b54bdefea0a@sphcmbx02.sunplus.com.tw>
Date:   Tue, 19 Apr 2022 10:07:55 +0000
From:   Wells Lu 呂芳騰 <wells.lu@...plus.com>
To:     Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>
CC:     Wells Lu <wellslutw@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "roopa@...dia.com" <roopa@...dia.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>
Subject: RE: [PATCH net-next v8 2/2] net: ethernet: Add driver for Sunplus
 SP7021

> > > +		/* Get mac-address from nvmem. */
> > > +		ret = spl2sw_nvmem_get_mac_address(&pdev->dev, port_np, mac_addr);
> > > +		if (ret) {
> > > +			dev_info(&pdev->dev, "Generate a random mac address!\n");
> > > +
> > > +			/* Generate a mac address using OUI of Sunplus Technology
> > > +			 * and random controller number.
> > > +			 */
> > > +			mac_addr[0] = 0xfc; /* OUI of Sunplus: fc:4b:bc */
> > > +			mac_addr[1] = 0x4b;
> > > +			mac_addr[2] = 0xbc;
> > > +			mac_addr[3] = get_random_int() % 256;
> > > +			mac_addr[4] = get_random_int() % 256;
> > > +			mac_addr[5] = get_random_int() % 256;
> >
> > I don't think you can do that. Either you use your OUI and assign the
> > address at manufacture or you must use a locally administered address.
> > And if locally administered address is used it better be completely
> > random to lower the probability of collision to absolute minimum.
> 
> I commented about that in an earlier version of these patches. We probably need a quote
> from the 802.1 or 802.3 which says this is O.K.
> 
> 	 Andrew

Hi Andrew,

I plan to replace above statements with:

	eth_random_addr(mac_addr);

eth_random_addr() generates locally administered (random) address.

Do you mean I can keep use the mac address: "OUI + random number"?
Only need to add comment for it. 
What comment should I add? Which one do you recommend?

Thank you very much for your review.


Best regards,
Wells