linux-kernel - Re: [PATCH] net/smc: sync err info when TCP connection is refused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed643c3d-6ad0-1b3c-1fe3-9157e7aa5859@linux.ibm.com>
Date:   Tue, 19 Apr 2022 12:37:12 +0200
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     Tony Lu <tonylu@...ux.alibaba.com>, yacanliu@....com
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, liuyacan <liuyacan@...p.netease.com>
Subject: Re: [PATCH] net/smc: sync err info when TCP connection is refused

On 19/04/2022 12:23, Tony Lu wrote:
> On Sun, Apr 17, 2022 at 08:33:07PM +0800, yacanliu@....com wrote:
>> From: liuyacan <liuyacan@...p.netease.com>
>>
>> In the current implementation, when TCP initiates a connection
>> to an unavailable [ip,port], ECONNREFUSED will be stored in the
>> TCP socket, but SMC will not. However, some apps (like curl) use
>> getsockopt(,,SO_ERROR,,) to get the error information, which makes
>> them miss the error message and behave strangely.
>>
>> Signed-off-by: liuyacan <liuyacan@...p.netease.com>
> 
> This fix works for me. I have tested it with curl for unavailable
> address.
> 
> This patch missed net or net-next tag, I think net is preferred.
> 
> Reviewed-by: Tony Lu <tonylu@...ux.alibaba.com>
> 
> Thank you,
> Tony Lu

Thank you both for the fix and the test!

Acked-by: Karsten Graul <kgraul@...ux.ibm.com>