linux-kernel - Re: [PATCH] USB: using pm_runtime_resume_and_get instead of pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f0dd8e6d0d6d01483e21e7702f5f59ad60a077c.camel@hadess.net>
Date:   Tue, 19 Apr 2022 13:08:58 +0200
From:   Bastien Nocera <hadess@...ess.net>
To:     cgel.zte@...il.com
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] USB: using pm_runtime_resume_and_get instead of
 pm_runtime_get_sync

On Tue, 2022-04-19 at 11:05 +0000, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. This change is just to simplify the code, no
> actual functional changes.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>

Reviewed-by: Bastien Nocera <hadess@...ess.net>

Thanks!

> ---
>  drivers/usb/misc/apple-mfi-fastcharge.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c
> b/drivers/usb/misc/apple-mfi-fastcharge.c
> index ac8695195c13..fba102245d8f 100644
> --- a/drivers/usb/misc/apple-mfi-fastcharge.c
> +++ b/drivers/usb/misc/apple-mfi-fastcharge.c
> @@ -119,11 +119,9 @@ static int apple_mfi_fc_set_property(struct
> power_supply *psy,
>  
>         dev_dbg(&mfi->udev->dev, "prop: %d\n", psp);
>  
> -       ret = pm_runtime_get_sync(&mfi->udev->dev);
> -       if (ret < 0) {
> -               pm_runtime_put_noidle(&mfi->udev->dev);
> +       ret = pm_runtime_resume_and_get(&mfi->udev->dev);
> +       if (ret < 0)
>                 return ret;
> -       }
>  
>         switch (psp) {
>         case POWER_SUPPLY_PROP_CHARGE_TYPE: