linux-kernel - Re: [PATCH] Documentation/vm: Include kernel-doc from highmem-internal.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2824835.e9J7NaK4W3@leap>
Date:   Tue, 19 Apr 2022 14:35:48 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Ira Weiny <ira.weiny@...el.com>
Cc:     Jonathan Corbet <corbet@....net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        SeongJae Park <sj@...nel.org>,
        Jiajian Ye <yejiajian2018@...il.szu.edu.cn>,
        Thomas Gleixner <tglx@...utronix.de>,
        Matthew Wilcox <willy@...radead.org>,
        Peter Zijlstra <peterz@...radead.org>,
        outreachy@...ts.linux.dev, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation/vm: Include kernel-doc from highmem-internal.h

On lunedì 18 aprile 2022 23:36:49 CEST Ira Weiny wrote:
> On Mon, Apr 18, 2022 at 10:17:40AM +0200, Fabio M. De Francesco wrote:
> > In Documentation/vm/highmem.rst the kernel-doc comments are missing,
> > therefore kunmap_local() and kunmap_atomic() are yet undocumented.
> > 
> > Add a kernel-doc directive to include the above-mentioned kernel-doc
> > comments in highmem.rst.
> > 
> > Cc: Jonathan Corbet <corbet@....net>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Ira Weiny <ira.weiny@...el.com>
> > Cc: Matthew Wilcox <willy@...radead.org>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> 
> I thought I saw a patch fly by which changed the comment of 
kunmap_atomic() in
> include/linux/highmem-internal.h?  Did I miss that somewhere?

Sorry, in my other email I responded after misunderstanding your question 
because I had just noticed a typo so that I had something else in my mind.

It looks that you are talking about the following patch and, if so, you saw 
it correctly:

"[PATCH v2] mm/highmem: Fix kernel-doc warnings in highmem*.h" at 
https://lore.kernel.org/lkml/20220418175638.30018-1-fmdefrancesco@gmail.com/

I forgot to send it to the Outreachy list. I'm about to resend it only to 
this list in order to make Outreachy's organizers to know about it. For v1 
already had an "Acked-by:" tag from Mike Rapoport.

Thanks,

Fabio M. De Francesco