linux-kernel - Re: [PATCH v2] mm/mmzone: Introduce a new macro for_each_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1126a1ae-8eff-8962-4253-d6e430ecc892@redhat.com>
Date:   Tue, 19 Apr 2022 14:53:16 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Mike Rapoport <rppt@...nel.org>, Donghyeok Kim <dthex5d@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Ohhoon Kwon <ohkwon1043@...il.com>,
        JaeSang Yoo <jsyoo5b@...il.com>,
        Wonhyuk Yang <vvghjk1234@...il.com>,
        Jiyoup Kim <lakroforce@...il.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/mmzone: Introduce a new macro
 for_each_node_zonelist()

On 18.04.22 16:05, Mike Rapoport wrote:
> On Sat, Apr 16, 2022 at 10:20:35PM +0900, Donghyeok Kim wrote:
>> There are some codes using for_each_zone_zonelist() even when only
>> iterating each node is needed. This commit introduces a new macro
>> for_each_node_zonelist() which iterates through valid nodes in the
>> zonelist.
>>
>> By using this new macro, code can be written in a much simpler form.
>> Also, slab/slub can now skip trying to allocate from the node which was
>> previously tried and failed.
>>
>> Co-developed-by: Ohhoon Kwon <ohkwon1043@...il.com>
>> Signed-off-by: Ohhoon Kwon <ohkwon1043@...il.com>
>> Signed-off-by: Donghyeok Kim <dthex5d@...il.com>
>> ---
>> V1 -> V2: Fix a compile error
>>
>>  include/linux/mmzone.h | 36 ++++++++++++++++++++++++++++++++++++
>>  mm/hugetlb.c           | 17 +++++++----------
>>  mm/mmzone.c            | 17 +++++++++++++++++
>>  mm/slab.c              |  7 ++-----
>>  mm/slub.c              |  8 ++++----
>>  mm/vmscan.c            | 16 ++++++----------
>>  6 files changed, 72 insertions(+), 29 deletions(-)
> 
> Even counting the comments this does not look like a great simplification.
> 

I tend to agree.


-- 
Thanks,

David / dhildenb