linux-kernel - Re: [PATCH V5 5/8] perf/tools: Add system error and not in transaction branch types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfd80315-ff94-1394-f194-be9eec0d9202@arm.com>
Date:   Tue, 19 Apr 2022 14:58:01 +0100
From:   James Clark <james.clark@....com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        peterz@...radead.org, acme@...nel.org
Cc:     Robin Murphy <robin.murphy@....com>,
        Suzuki Poulose <suzuki.poulose@....com>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V5 5/8] perf/tools: Add system error and not in
 transaction branch types



On 04/04/2022 05:50, Anshuman Khandual wrote:
> This updates the perf tool with generic branch type classification with two
> new branch types i.e system error (PERF_BR_SERROR) and not in transaction
> (PERF_BR_NO_TX) which got updated earlier in the kernel. This also updates
> corresponding branch type strings in branch_type_name().
> 
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Will Deacon <will@...nel.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-perf-users@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
Reviewed-by: James Clark <james.clark@....com>

> ---
>  tools/include/uapi/linux/perf_event.h | 2 ++
>  tools/perf/util/branch.c              | 4 +++-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h
> index d37629dbad72..26d8f0b5ac0d 100644
> --- a/tools/include/uapi/linux/perf_event.h
> +++ b/tools/include/uapi/linux/perf_event.h
> @@ -253,6 +253,8 @@ enum {
>  	PERF_BR_COND_RET	= 10,	/* conditional function return */
>  	PERF_BR_ERET		= 11,	/* exception return */
>  	PERF_BR_IRQ		= 12,	/* irq */
> +	PERF_BR_SERROR		= 13,	/* system error */
> +	PERF_BR_NO_TX		= 14,	/* not in transaction */
>  	PERF_BR_MAX,
>  };
>  
> diff --git a/tools/perf/util/branch.c b/tools/perf/util/branch.c
> index a9a909db8cc7..abc673347bee 100644
> --- a/tools/perf/util/branch.c
> +++ b/tools/perf/util/branch.c
> @@ -51,7 +51,9 @@ const char *branch_type_name(int type)
>  		"COND_CALL",
>  		"COND_RET",
>  		"ERET",
> -		"IRQ"
> +		"IRQ",
> +		"SERROR",
> +		"NO_TX"
>  	};
>  
>  	if (type >= 0 && type < PERF_BR_MAX)