linux-kernel - Re: [PATCH v2 1/2] x86/cpufeatures: Add virtual TSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e5f976aa-d993-7e4a-c69d-e02e86bec1f4@redhat.com>
Date:   Wed, 20 Apr 2022 18:27:23 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Babu Moger <babu.moger@....com>, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        hpa@...or.com, seanjc@...gle.com
Cc:     vkuznets@...hat.com, jmattson@...gle.com, joro@...tes.org,
        wanpengli@...cent.com, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH v2 1/2] x86/cpufeatures: Add virtual TSC_AUX feature bit

On 4/19/22 22:53, Babu Moger wrote:
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> index b24ca7f4ed7c..99a4c078b397 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -674,7 +674,7 @@ void kvm_set_cpu_caps(void)
>   
>   	kvm_cpu_cap_mask(CPUID_8000_001F_EAX,
>   		0 /* SME */ | F(SEV) | 0 /* VM_PAGE_FLUSH */ | F(SEV_ES) |
> -		F(SME_COHERENT));
> +		F(V_TSC_AUX) | F(SME_COHERENT));
>   
>   	kvm_cpu_cap_mask(CPUID_C000_0001_EDX,
>   		F(XSTORE) | F(XSTORE_EN) | F(XCRYPT) | F(XCRYPT_EN) |

Not needed, since V_TSC_AUX is not exposed to guests.

I made the changes and queued both patches.

Paolo