linux-kernel - Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d84f994d-e291-84d0-5576-571984cf5018@roeck-us.net>
Date:   Wed, 20 Apr 2022 09:36:38 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Hawkins, Nick" <nick.hawkins@....com>,
        "Verdun, Jean-Marie" <verdun@....com>,
        "Harders, Nick" <nicholas.harders@....com>,
        "joel@....id.au" <joel@....id.au>, "arnd@...db.de" <arnd@...db.de>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Rob Herring <robh+dt@...nel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog
 timer binding

On 4/20/22 09:08, Hawkins, Nick wrote:
> 
> 
> -----Original Message-----
> From: Guenter Roeck [mailto:groeck7@...il.com] On Behalf Of Guenter Roeck
> Sent: Wednesday, April 20, 2022 10:53 AM
> To: Hawkins, Nick <nick.hawkins@....com>; Verdun, Jean-Marie <verdun@....com>; Harders, Nick <nicholas.harders@....com>; joel@....id.au; arnd@...db.de
> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>; Rob Herring <robh+dt@...nel.org>; linux-watchdog@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding
> 
> On 4/20/22 08:01, nick.hawkins@....com wrote:
>>> From: Nick Hawkins <nick.hawkins@....com>
>>>
>>> Add the hpe gxp watchdog timer binding hpe,gxp-wdt.
>>> This will enable support for the HPE GXP Watchdog
>>>
>>> Signed-off-by: Nick Hawkins <nick.hawkins@....com>
>>>
>>> ---
>>> v2:
> 
>> v3 and v4 changes are missing.
> 
> I considered this the second attempt with a valid patchset but I will change this to v4 and add v3 v2. Should I make a v5 to say I updated the patch message?
> 

Sorry, I can't parse your statement. If there was no change in v3 and v4,
the change log for v3 and v4 should say "no changes in v3 and v4".
If the changes were made in v3 and/or v4, the change log should say that.
If the patch was added in v2/v3/v4, the change log should say that.
Either case, the last version in the change log should match the version
in the subject. Reviewers won't otherwise know how to match the patch
version with the change log. They will have to dig up v1..v3 to compare
the versions and find that out what exactly changed where (and why).
In my case, that commonly translates to "move patch to the end of my
review queue" because I just don't have the time to do that.

Guenter