linux-kernel - Re: [PATCH] firmware: edd: Remove redundant condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmBDgRYGdcjz3ppn@kroah.com>
Date:   Wed, 20 Apr 2022 19:31:45 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     白浩文 <baihaowen@...zu.com>
Cc:     "sudeep.holla@....com" <sudeep.holla@....com>,
        "cristian.marussi@....com" <cristian.marussi@....com>,
        "ardb@...nel.org" <ardb@...nel.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: edd: Remove redundant condition

On Fri, Mar 18, 2022 at 10:33:12PM +0000, 白浩文 wrote:
> Dear Greg KH
> 
> But the logic here is:
>         (!A || (A && B))
> not:
>         (!A || A && B)
> 
> as you write
> 
> No, what I wrote is
> 
> the logic here is:
>         (!A || (A && B))
> Is the same:
>         (!A || B)

That is not what your changelog text says, and I quote:

> > The logic !A || A && B is equivalent to !A || B. so we have
> > to make code clear.

(note, top-posting is horrid and is why we do not do this, please fix
this in the future.)

So can you please fix up your changelog text to be correct and resend
it?

thanks,

greg k-h