linux-kernel - Re: [PATCH -next] pinctrl: mediatek: moore: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYVHPA7GyjyeOU_Q78dZR_VD1-=6pVX74j5FKee7cKpGQ@mail.gmail.com>
Date:   Thu, 21 Apr 2022 00:50:15 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     sean.wang@...nel.org, matthias.bgg@...il.com,
        light.hsieh@...iatek.com, linux-mediatek@...ts.infradead.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next] pinctrl: mediatek: moore: Fix build error

On Sat, Apr 9, 2022 at 1:00 PM YueHaibing <yuehaibing@...wei.com> wrote:

> If EINT_MTK is m and PINCTRL_MTK_V2 is y, build fails:
>
> drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_set_config':
> pinctrl-moore.c:(.text+0xa6c): undefined reference to `mtk_eint_set_debounce'
> drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_to_irq':
> pinctrl-moore.c:(.text+0xacc): undefined reference to `mtk_eint_find_irq'
>
> Select EINT_MTK for PINCTRL_MTK_V2 to fix this.
>
> Fixes: 8174a8512e3e ("pinctrl: mediatek: make MediaTek pinctrl v2 driver ready for buidling loadable module")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Good catch! Patch applied for fixes.

Yours,
Linus Walleij