linux-kernel - Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYmw4yBm3Y1P42TcRs4fFNEiy3LXxmO_j=zeTv_usDR+g@mail.gmail.com>
Date:   Thu, 21 Apr 2022 01:24:51 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Maíra Canal <maira.canal@....br>
Cc:     hongxing.zhu@....com, l.stach@...gutronix.de,
        lorenzo.pieralisi@....com, robh@...nel.org, bhelgaas@...gle.com,
        helgaas@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, linux-imx@....com,
        linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod interface

Hi Maira and sorry for being slow on reviews.

On Tue, Nov 2, 2021 at 2:04 AM Maíra Canal <maira.canal@....br> wrote:

> -               gpio_set_value_cansleep(imx6_pcie->reset_gpio,
> +               gpiod_set_raw_value_cansleep(imx6_pcie->reset_gpio,
>                                         !imx6_pcie->gpio_active_high);

Hm I see you got advised to use the raw api. I'm not so sure about
that I like v1 better.

> +       imx6_pcie->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> +                       imx6_pcie->gpio_active_high ?  GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
> +       if (IS_ERR(imx6_pcie->reset_gpio))
> +               return dev_err_probe(dev, PTR_ERR(imx6_pcie->reset_gpio),
> +                               "unable to get reset gpio\n");

Where is this descriptor coming from? Device trees? Can't we just fix the
DTS file(s) in that case given how wrong they are if they don't set
GPIO_ACTIVE_LOW flag on this IRQ.

Yours,
Linus Walleij