linux-kernel - RE: [PATCH v2 2/5] scsi: ufshpb: Remove 0 assignment for enum value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Apr 2022 11:49:48 +0900
From:   Keoseong Park <keosung.park@...sung.com>
To:     Bean Huo <huobean@...il.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        Daejun Park <daejun7.park@...sung.com>,
        "powen.kao@...iatek.com" <powen.kao@...iatek.com>,
        "peter.wang@...iatek.com" <peter.wang@...iatek.com>,
        cpgsproxy3 <cpgsproxy3@...sung.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 2/5] scsi: ufshpb: Remove 0 assignment for enum value

>From: Bean Huo <beanhuo@...ron.com>
> 
>If the first enumerator has no initializer, the value of the corresponding
>constant is zero.
> 
>Signed-off-by: Bean Huo <beanhuo@...ron.com>
>---
> drivers/scsi/ufs/ufshpb.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
>diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
>index 2825ec69a6a6..b7e2817d4e76 100644
>--- a/drivers/scsi/ufs/ufshpb.h
>+++ b/drivers/scsi/ufs/ufshpb.h
>@@ -59,8 +59,8 @@ enum UFSHPB_MODE {
> };
> 
> enum UFSHPB_STATE {
>-        HPB_INIT = 0,
>-        HPB_PRESENT = 1,
>+        HPB_INIT,
>+        HPB_PRESENT,
>         HPB_SUSPEND,
>         HPB_FAILED,
>         HPB_RESET,
>-- 
>2.34.1
> 

Reviewed-by: Keoseong Park <keosung.park@...sung.com>

Best Regards,
Keoseong Park