linux-kernel - Re: [PATCH] mtd: spi-nor: move SECT_4K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220420062716.zhs3y4koirjpshqw@ti.com>
Date:   Wed, 20 Apr 2022 11:57:16 +0530
From:   Pratyush Yadav <p.yadav@...com>
To:     Michael Walle <michael@...le.cc>
CC:     Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: move SECT_4K_PMC special handling

On 18/04/22 01:26PM, Michael Walle wrote:
> The SECT_4K_PMC flag will set a device specific opcode for the 4k sector
> erase. Instead of handling it in the core, we can move it to a
> late_init(). In that late init, loop over all erase types, look for the
> 4k size and replace the opcode.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
> Please have a closer look here. This is only compile time tested. Also
> I didn't see much reason to reorder the flags.

Patch looks okay to me but I would like someone to test it on the flash 
before I apply it.

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.