linux-kernel - Re: [PATCH -next v4 1/4] mm: page_table_check: move pxx_user_accessible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c376877e-53a7-d471-61bc-e7f9dd400d60@huawei.com>
Date:   Wed, 20 Apr 2022 14:44:10 +0800
From:   Tong Tiangen <tongtiangen@...wei.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Pasha Tatashin <pasha.tatashin@...een.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>
CC:     <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-riscv@...ts.infradead.org>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Guohanjun <guohanjun@...wei.com>
Subject: Re: [PATCH -next v4 1/4] mm: page_table_check: move
 pxx_user_accessible_page into x86



在 2022/4/19 17:29, Anshuman Khandual 写道:
> 
> 
> On 4/18/22 09:14, Tong Tiangen wrote:
>> --- a/mm/page_table_check.c
>> +++ b/mm/page_table_check.c
>> @@ -10,6 +10,14 @@
>>   #undef pr_fmt
>>   #define pr_fmt(fmt)	"page_table_check: " fmt
>>   
>> +#ifndef PMD_PAGE_SIZE
>> +#define PMD_PAGE_SIZE	PMD_SIZE
>> +#endif
>> +
>> +#ifndef PUD_PAGE_SIZE
>> +#define PUD_PAGE_SIZE	PUD_SIZE
>> +#endif
> 
> Why cannot PMD_SIZE/PUD_SIZE be used on every platform instead ? What is the
> need for using PUD_PAGE_SIZE/PMD_PAGE_SIZE ? Are they different on x86 ?
> .

Hi, Pasha：
I checked the definitions of PMD_SIZE/PUD_SIZE and 
PUD_PAGE_SIZE/PMD_PAGE_SIZE in x86 architecture and their use outside 
the architecture(eg: in mm/, all used PMD_SIZE/PUD_SIZE), Would it be 
better to use a unified PMD_SIZE/PUD_SIZE here?

Thanks,
Tong.