linux-kernel - Re: [PATCH 2/3] dt-bindings: arm: mediatek: apmixedsys: Convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <958e076f-4567-3941-69cb-69d819de2470@linaro.org>
Date:   Wed, 20 Apr 2022 08:50:02 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Yassine Oudjana <yassine.oudjana@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     Sam Shih <sam.shih@...iatek.com>, Stephen Boyd <sboyd@...nel.org>,
        Ryder Lee <ryder.lee@...nel.org>,
        Yassine Oudjana <y.oudjana@...tonmail.com>,
        devicetree@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: arm: mediatek: apmixedsys: Convert to DT
 schema

On 19/04/2022 20:09, Yassine Oudjana wrote:

Thank you for your patch. There is something to discuss/improve.

> +
> +title: MediaTek AP Mixedsys Controller
> +
> +maintainers:
> +  - Matthias Brugger <matthias.bgg@...il.com>
> +
> +description:
> +  The Mediatek apmixedsys controller provides PLLs to the system.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:

Same comments as patch 1 - no need for items here, just enum. Please
also put the new binding in clock subsystem.

Best regards,
Krzysztof