linux-kernel - Re: [PATCH -next] cpuidle: riscv: support non-SMP config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Apr 2022 18:07:32 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...osinc.com>
To:     rdunlap@...radead.org
CC:     linux-kernel@...r.kernel.org, rdunlap@...radead.org, lkp@...el.com,
        anup@...infault.org, anup@...infault.org, apatel@...tanamicro.com,
        Atish Patra <atishp@...osinc.com>, daniel.lezcano@...aro.org,
        rafael@...nel.org, linux-pm@...r.kernel.org,
        linux-riscv@...ts.infradead.org,
        Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu
Subject:     Re: [PATCH -next] cpuidle: riscv: support non-SMP config

On Sat, 02 Apr 2022 20:13:55 PDT (-0700), rdunlap@...radead.org wrote:
> Add <asm/smp.h> for cpuid_to_hartid_map etc.
> This is needed for both SMP and non-SMP builds, but not having it
> causes a build error for non-SMP:
>
> drivers/cpuidle/cpuidle-riscv-sbi.c: In function 'sbi_cpuidle_init_cpu':
> drivers/cpuidle/cpuidle-riscv-sbi.c:350:26: error: implicit declaration of function 'cpuid_to_hartid_map' [-Werror=implicit-function-declaration]
>
> Fixes: 6abf32f1d9c5 ("cpuidle: Add RISC-V SBI CPU idle driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Anup Patel <anup.patel@....com>
> Cc: Anup Patel <anup@...infault.org>
> Cc: Anup Patel <apatel@...tanamicro.com>
> Cc: Atish Patra <atishp@...osinc.com>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: linux-pm@...r.kernel.org
> Cc: linux-riscv@...ts.infradead.org
> Cc: Palmer Dabbelt <palmer@...osinc.com>
> Cc: Paul Walmsley <paul.walmsley@...ive.com>
> Cc: Albert Ou <aou@...s.berkeley.edu>
> ---
>  drivers/cpuidle/cpuidle-riscv-sbi.c |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20220401.orig/drivers/cpuidle/cpuidle-riscv-sbi.c
> +++ linux-next-20220401/drivers/cpuidle/cpuidle-riscv-sbi.c
> @@ -22,6 +22,7 @@
>  #include <linux/pm_runtime.h>
>  #include <asm/cpuidle.h>
>  #include <asm/sbi.h>
> +#include <asm/smp.h>
>  #include <asm/suspend.h>
>
>  #include "dt_idle_states.h"

Thanks, this is on fixes.