lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202204201625.mqL2ajMD-lkp@intel.com>
Date:   Wed, 20 Apr 2022 16:34:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [mingo-tip:sched/headers 2149/2579] kernel/up.c:15:5: warning: no
 previous prototype for 'smp_call_function_single'

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git sched/headers
head:   49e1ec6c70a6eb4b7de9250a455b8b63eb42afbe
commit: fd8fff89ec8a3b5eb545b66dff7a4875b5b5c9ab [2149/2579] headers/deps: genirq: Optimize <linux/interrupt.h> dependencies, remove <linux/hardirq.h>
config: mips-randconfig-r032-20220419 (https://download.01.org/0day-ci/archive/20220420/202204201625.mqL2ajMD-lkp@intel.com/config)
compiler: mipsel-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/commit/?id=fd8fff89ec8a3b5eb545b66dff7a4875b5b5c9ab
        git remote add mingo-tip git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git
        git fetch --no-tags mingo-tip sched/headers
        git checkout fd8fff89ec8a3b5eb545b66dff7a4875b5b5c9ab
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/interrupt.h:23,
                    from kernel/up.c:9:
   arch/mips/include/asm/irq.h:23:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'init_IRQ'
      23 | extern void __init init_IRQ(void);
         |                    ^~~~~~~~
>> kernel/up.c:15:5: warning: no previous prototype for 'smp_call_function_single' [-Wmissing-prototypes]
      15 | int smp_call_function_single(int cpu, void (*func) (void *info), void *info,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/up.c:31:5: warning: no previous prototype for 'smp_call_function_single_async' [-Wmissing-prototypes]
      31 | int smp_call_function_single_async(int cpu, struct __call_single_data *csd)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/up.c:46:6: warning: no previous prototype for 'on_each_cpu_cond_mask' [-Wmissing-prototypes]
      46 | void on_each_cpu_cond_mask(smp_cond_func_t cond_func, smp_call_func_t func,
         |      ^~~~~~~~~~~~~~~~~~~~~
>> kernel/up.c:61:5: warning: no previous prototype for 'smp_call_on_cpu' [-Wmissing-prototypes]
      61 | int smp_call_on_cpu(unsigned int cpu, int (*func)(void *), void *par, bool phys)
         |     ^~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SSB_EMBEDDED
   Depends on SSB && SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
   Selected by
   - BCM47XX_SSB && BCM47XX


vim +/smp_call_function_single +15 kernel/up.c

53ce3d95649087 Andrew Morton             2009-01-09  14  
53ce3d95649087 Andrew Morton             2009-01-09 @15  int smp_call_function_single(int cpu, void (*func) (void *info), void *info,
53ce3d95649087 Andrew Morton             2009-01-09  16  				int wait)
53ce3d95649087 Andrew Morton             2009-01-09  17  {
081192b25c2d46 David Daney               2013-09-11  18  	unsigned long flags;
081192b25c2d46 David Daney               2013-09-11  19  
1e474b28e78897 Paul E. McKenney          2020-02-05  20  	if (cpu != 0)
1e474b28e78897 Paul E. McKenney          2020-02-05  21  		return -ENXIO;
93423b8665f43a Ingo Molnar               2009-01-11  22  
081192b25c2d46 David Daney               2013-09-11  23  	local_irq_save(flags);
081192b25c2d46 David Daney               2013-09-11  24  	func(info);
081192b25c2d46 David Daney               2013-09-11  25  	local_irq_restore(flags);
93423b8665f43a Ingo Molnar               2009-01-11  26  
53ce3d95649087 Andrew Morton             2009-01-09  27  	return 0;
53ce3d95649087 Andrew Morton             2009-01-09  28  }
53ce3d95649087 Andrew Morton             2009-01-09  29  EXPORT_SYMBOL(smp_call_function_single);
fa688207c9db48 David Daney               2013-09-11  30  
1139aeb1c521eb Arnd Bergmann             2021-05-05 @31  int smp_call_function_single_async(int cpu, struct __call_single_data *csd)
40c01e8bd5575e Christoph Hellwig         2013-11-14  32  {
40c01e8bd5575e Christoph Hellwig         2013-11-14  33  	unsigned long flags;
40c01e8bd5575e Christoph Hellwig         2013-11-14  34  
40c01e8bd5575e Christoph Hellwig         2013-11-14  35  	local_irq_save(flags);
40c01e8bd5575e Christoph Hellwig         2013-11-14  36  	csd->func(csd->info);
40c01e8bd5575e Christoph Hellwig         2013-11-14  37  	local_irq_restore(flags);
08eed44c7249d3 Jan Kara                  2014-02-24  38  	return 0;
40c01e8bd5575e Christoph Hellwig         2013-11-14  39  }
c46fff2a3b2979 Frederic Weisbecker       2014-02-24  40  EXPORT_SYMBOL(smp_call_function_single_async);
40c01e8bd5575e Christoph Hellwig         2013-11-14  41  
fa688207c9db48 David Daney               2013-09-11  42  /*
fa688207c9db48 David Daney               2013-09-11  43   * Preemption is disabled here to make sure the cond_func is called under the
f0fffaff0b8960 Bhaskar Chowdhury         2021-05-06  44   * same conditions in UP and SMP.
fa688207c9db48 David Daney               2013-09-11  45   */
5671d814dbd204 Sebastian Andrzej Siewior 2020-01-17 @46  void on_each_cpu_cond_mask(smp_cond_func_t cond_func, smp_call_func_t func,
cb923159bbb8cc Sebastian Andrzej Siewior 2020-01-17  47  			   void *info, bool wait, const struct cpumask *mask)
fa688207c9db48 David Daney               2013-09-11  48  {
fa688207c9db48 David Daney               2013-09-11  49  	unsigned long flags;
fa688207c9db48 David Daney               2013-09-11  50  
fa688207c9db48 David Daney               2013-09-11  51  	preempt_disable();
a5aa5ce3005972 Nadav Amit                2021-02-20  52  	if ((!cond_func || cond_func(0, info)) && cpumask_test_cpu(0, mask)) {
fa688207c9db48 David Daney               2013-09-11  53  		local_irq_save(flags);
fa688207c9db48 David Daney               2013-09-11  54  		func(info);
fa688207c9db48 David Daney               2013-09-11  55  		local_irq_restore(flags);
fa688207c9db48 David Daney               2013-09-11  56  	}
fa688207c9db48 David Daney               2013-09-11  57  	preempt_enable();
fa688207c9db48 David Daney               2013-09-11  58  }
7d49b28a80b830 Rik van Riel              2018-09-25  59  EXPORT_SYMBOL(on_each_cpu_cond_mask);
7d49b28a80b830 Rik van Riel              2018-09-25  60  
df8ce9d78a4e7f Juergen Gross             2016-08-29 @61  int smp_call_on_cpu(unsigned int cpu, int (*func)(void *), void *par, bool phys)

:::::: The code at line 15 was first introduced by commit
:::::: 53ce3d9564908794ae7dd32969089b57df5fc098 smp_call_function_single(): be slightly less stupid

:::::: TO: Andrew Morton <akpm@...ux-foundation.org>
:::::: CC: Ingo Molnar <mingo@...e.hu>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ