linux-kernel - Re: [PATCH printk v3 14/15] printk: extend console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202204201041.ZwRzv18o-lkp@intel.com>
Date:   Wed, 20 Apr 2022 10:13:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     John Ogness <john.ogness@...utronix.de>,
        Petr Mladek <pmladek@...e.com>
Cc:     kbuild-all@...ts.01.org,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH printk v3 14/15] printk: extend console_lock for proper
 kthread support

Hi John,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 84d7df104dbab9c3dda8f2c5b46f9a6fc256fe02]

url:    https://github.com/intel-lab-lkp/linux/commits/John-Ogness/printk-for-next/20220420-080725
base:   84d7df104dbab9c3dda8f2c5b46f9a6fc256fe02
config: openrisc-randconfig-r022-20220419 (https://download.01.org/0day-ci/archive/20220420/202204201041.ZwRzv18o-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5139c5b347088e124f3812a3fa63eb284b14f2dc
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review John-Ogness/printk-for-next/20220420-080725
        git checkout 5139c5b347088e124f3812a3fa63eb284b14f2dc
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash kernel/printk/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> kernel/printk/printk.c:2703:6: warning: no previous prototype for 'console_lock_single_hold' [-Wmissing-prototypes]
    2703 | void console_lock_single_hold(struct console *con)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/console_lock_single_hold +2703 kernel/printk/printk.c

  2697	
  2698	/*
  2699	 * Lock the console_lock, but rather than blocking all the kthread printers,
  2700	 * lock a specified kthread printer and hold the lock. This is useful if
  2701	 * console flags for a particular console need to be updated.
  2702	 */
> 2703	void console_lock_single_hold(struct console *con)
  2704	{
  2705		might_sleep();
  2706		down_console_sem();
  2707		mutex_lock(&con->lock);
  2708		console_locked = 1;
  2709		console_may_schedule = 1;
  2710	}
  2711	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp