linux-kernel - Re: [PATCH v2 4/5] scsi: ufshpb: Add handing of device reset HPB regions Infos in HPB device mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d26393a3323dc646df88fb09ee47d712c80eafc9.camel@gmail.com>
Date:   Wed, 20 Apr 2022 15:21:41 +0200
From:   Bean Huo <huobean@...il.com>
To:     keosung.park@...sung.com, ALIM AKHTAR <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        Daejun Park <daejun7.park@...sung.com>,
        "powen.kao@...iatek.com" <powen.kao@...iatek.com>,
        "peter.wang@...iatek.com" <peter.wang@...iatek.com>,
        cpgsproxy3 <cpgsproxy3@...sung.com>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/5] scsi: ufshpb: Add handing of device reset HPB
 regions Infos in HPB device mode

On Wed, 2022-04-20 at 14:31 +0900, Keoseong Park wrote:
> > +/**
> > + *ufshpb_submit_region_inactive() - submit a region to be
> > inactivated later
> > + *@hpb: per-LU HPB instance
> > + *@...ion_index: the index associated with the region that will be
> > inactivated later
> > + */
> > +static void ufshpb_submit_region_inactive(struct ufshpb_lu *hpb,
> > int region_index)
> > +{
> > +        int subregion_index;
> > +        struct ufshpb_region *rgn;
> > +        struct ufshpb_subregion *srgn;
> > +
> > +        /*
> > +         * Remove this region from active region list and add it
> > to inactive list
> > +         */
> > +        spin_lock(&hpb->rsp_list_lock);
> > +        ufshpb_update_inactive_info(hpb, region_index);
> How about separating the "hpb->stats.rb_inactive_cnt++" code from
> ufshpb_update_inactive_info()?
> Because I think this code should only be used in
> ufshpb_rsp_req_region_update().


based on Documentation/ABI/testing/sysfs-driver-ufs:

"What:       /sys/class/scsi_device/*/device/hpb_stats/rb_inactive_cnt
Date:       June 2021
Contact:    Daejun Park <daejun7.park@...sung.com>
Description:    This entry shows the number of inactive regions
recommended by  response UPIUs."


This parameter should be increased only when recieving inactive
recommended.

I will change it in the next version, thanks.


Kind regards,
Bean