linux-kernel - Re: [PATCH v2 2/2] dmaengine: apple-admac: Add Apple ADMAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <69599B8F-8F88-42BC-B159-863D1F9E729A@cutebit.org>
Date:   Wed, 20 Apr 2022 15:41:37 +0200
From:   Martin Povišer <povik@...ebit.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Martin Povišer <povik+lin@...ebit.org>,
        Hector Martin <marcan@...can.st>,
        Sven Peter <sven@...npeter.dev>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mark Kettenis <kettenis@...nbsd.org>
Subject: Re: [PATCH v2 2/2] dmaengine: apple-admac: Add Apple ADMAC driver


> On 20. 4. 2022, at 14:40, Vinod Koul <vkoul@...nel.org> wrote:
> 
> On 12-04-22, 00:22, Martin Povišer wrote:
> 
>> +struct admac_chan {
>> +	int no;
> 
> Unsigned int perhaps?

Sure.

> 
>> +static int admac_desc_free(struct dma_async_tx_descriptor *tx)
>> +{
>> +	struct admac_tx *adtx = to_admac_tx(tx);
>> +
>> +	devm_kfree(to_admac_chan(tx->chan)->host->dev, adtx);
> 
> Why use devm for descriptor memory?

Well, good point. :-)

>> +static int admac_device_config(struct dma_chan *chan,
>> +			       struct dma_slave_config *config)
>> +{
>> +	struct admac_chan *adchan = to_admac_chan(chan);
>> +	struct admac_data *ad = adchan->host;
>> +	bool is_tx = admac_chan_direction(adchan->no) == DMA_MEM_TO_DEV;
> 
> so are the channel directions hard wired in hardware?

Yes they are.

> -- 
> ~Vinod

Martin