linux-kernel - Re: [PATCH printk v3 05/15] printk: wake waiters for safe and NMI contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmAQyvPEwy5XaKWl@alley>
Date:   Wed, 20 Apr 2022 15:55:22 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     John Ogness <john.ogness@...utronix.de>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH printk v3 05/15] printk: wake waiters for safe and NMI
 contexts

On Wed 2022-04-20 01:52:27, John Ogness wrote:
> When printk() is called from safe or NMI contexts, it will directly
> store the record (vprintk_store()) and then defer the console output.
> However, defer_console_output() only causes console printing and does
> not wake any waiters of new records.
> 
> Wake waiters from defer_console_output() so that they also are aware
> of the new records from safe and NMI contexts.
> 
> Fixes: 03fc7f9c99c1 ("printk/nmi: Prevent deadlock when accessing the main log buffer in NMI")
> Signed-off-by: John Ogness <john.ogness@...utronix.de>

Another great catch!

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr