linux-kernel - Re: [PATCH 2/2] pinctrl: rockchip: sort the rk3308_mux_recalced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Apr 2022 17:05:06 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     linux-gpio@...r.kernel.org,
        Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc:     Luca Ceresoli <luca.ceresoli@...tlin.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jianqun Xu <jay.xu@...k-chips.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: rockchip: sort the rk3308_mux_recalced_data entries

Am Mittwoch, 20. April 2022, 16:24:32 CEST schrieb Luca Ceresoli:
> All the entries are sorted according to num/pin except for two
> entries. Sort them too.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/pinctrl/pinctrl-rockchip.c | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index 65fa305b5f59..2cb79e649fcf 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -512,20 +512,6 @@ static struct rockchip_mux_recalced_data rk3308_mux_recalced_data[] = {
>  		.reg = 0x34,
>  		.bit = 8,
>  		.mask = 0xf
> -	}, {
> -		/* gpio3b4_sel */
> -		.num = 3,
> -		.pin = 12,
> -		.reg = 0x68,
> -		.bit = 8,
> -		.mask = 0xf
> -	}, {
> -		/* gpio3b5_sel */
> -		.num = 3,
> -		.pin = 13,
> -		.reg = 0x68,
> -		.bit = 12,
> -		.mask = 0xf
>  	}, {
>  		/* gpio2a2_sel */
>  		.num = 2,
> @@ -561,6 +547,20 @@ static struct rockchip_mux_recalced_data rk3308_mux_recalced_data[] = {
>  		.reg = 0x68,
>  		.bit = 6,
>  		.mask = 0x3
> +	}, {
> +		/* gpio3b4_sel */
> +		.num = 3,
> +		.pin = 12,
> +		.reg = 0x68,
> +		.bit = 8,
> +		.mask = 0xf
> +	}, {
> +		/* gpio3b5_sel */
> +		.num = 3,
> +		.pin = 13,
> +		.reg = 0x68,
> +		.bit = 12,
> +		.mask = 0xf
>  	},
>  };
>  
>