[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YmAljQjpLCoBv+nj@sirena.org.uk>
Date: Wed, 20 Apr 2022 16:23:57 +0100
From: Mark Brown <broonie@...nel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc: cgel.zte@...il.com, lgirdwood@...il.com,
ranjani.sridharan@...ux.intel.com, kai.vehmanen@...ux.intel.com,
daniel.baluta@....com, sound-open-firmware@...a-project.org,
alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
Minghao Chi <chi.minghao@....com.cn>,
Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] ASoC: SOF: using pm_runtime_resume_and_get to simplify
the code
On Wed, Apr 20, 2022 at 08:28:31AM -0500, Pierre-Louis Bossart wrote:
> On 4/19/22 22:03, cgel.zte@...il.com wrote:
> > From: Minghao Chi <chi.minghao@....com.cn>
> > Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> > pm_runtime_put_noidle. This change is just to simplify the code, no
> > actual functional changes.
> Well, maybe that's a simplification, but we've been using the same pattern for years now.
> Is there really a clear direction to use this new function?
It seems like a much better pattern and there's been a steady stream of
conversion patches. The whole get/idle thing is pretty much just sharp
edges.
> the overwhelming majority of drivers in sound/soc still rely on the pm_runtime_get_sync (111 v. 7).
We'll get there I'm sure.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists