linux-kernel - RE: [V4 1/2] ASoC: max98390: Add reset gpio control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR03MB678610A794CC939AD3AA117999F49@PH0PR03MB6786.namprd03.prod.outlook.com>
Date:   Thu, 21 Apr 2022 14:39:53 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Steve Lee <steve.lee.analog@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
CC:     "krzk@...nel.org" <krzk@...nel.org>,
        "Lee, RyanS" <RyanS.Lee@...log.com>
Subject: RE: [V4 1/2] ASoC: max98390: Add reset gpio control



> -----Original Message-----
> From: Steve Lee <steve.lee.analog@...il.com>
> Sent: Wednesday, April 20, 2022 6:49 AM
> To: lgirdwood@...il.com; broonie@...nel.org; perex@...ex.cz;
> tiwai@...e.com; linux-kernel@...r.kernel.org; alsa-devel@...a-
> project.org
> Cc: krzk@...nel.org; Sa, Nuno <Nuno.Sa@...log.com>; Lee, RyanS
> <RyanS.Lee@...log.com>; Steve Lee <steve.lee.analog@...il.com>
> Subject: [V4 1/2] ASoC: max98390: Add reset gpio control
> 
> [External]
> 
>  Add reset gpio control to support RESET PIN connected to gpio.
> 
> Signed-off-by: Steve Lee <steve.lee.analog@...il.com>
> ---
> V3 -> V4: change reset gpio control as GPIO_ACTIVE_LOW in DT
> 
>  sound/soc/codecs/max98390.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/sound/soc/codecs/max98390.c
> b/sound/soc/codecs/max98390.c
> index 40fd6f363f35..bdfd6cccc3d2 100644
> --- a/sound/soc/codecs/max98390.c
> +++ b/sound/soc/codecs/max98390.c
> @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct
> i2c_client *i2c,
> 
>  	struct max98390_priv *max98390 = NULL;
>  	struct i2c_adapter *adapter = i2c->adapter;
> +	struct gpio_desc *reset_gpio;
> 
>  	ret = i2c_check_functionality(adapter,
>  		I2C_FUNC_SMBUS_BYTE
> @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct
> i2c_client *i2c,
>  		return ret;
>  	}
> 
> +	reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> +					     "reset", GPIOD_OUT_HIGH);
> +
> +	/* Power on device */


I guess this comment is redundant as you already say
"bring out of reset" some lines below.

> +	if (reset_gpio) {
> +		usleep_range(1000, 2000);
> +		/* bring out of reset */
> +		gpiod_set_value_cansleep(reset_gpio, 0);
> +		usleep_range(1000, 2000);
> +	}
> +

Anyways,

Acked-by: Nuno Sá <nuno.sa@...log.com>