linux-kernel - Re: [PATCH 3/3] memblock tests: remove extra column of spaces in block comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YmFtYPlrJtv7iKh3@kernel.org>
Date:   Thu, 21 Apr 2022 17:42:40 +0300
From:   Mike Rapoport <rppt@...nel.org>
To:     David Hildenbrand <david@...hat.com>
Cc:     Rebecca Mckeever <remckee0@...il.com>, outreachy@...ts.linux.dev,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] memblock tests: remove extra column of spaces in
 block comment

On Thu, Apr 21, 2022 at 09:09:58AM +0200, David Hildenbrand wrote:
> On 20.04.22 13:19, Rebecca Mckeever wrote:
> > Remove extra space at the beginning of each line in block comment
> > for consistency and to conform to Linux kernel coding style.
> > 
> > Signed-off-by: Rebecca Mckeever <remckee0@...il.com>
> > ---
> >  tools/testing/memblock/tests/basic_api.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/tools/testing/memblock/tests/basic_api.c b/tools/testing/memblock/tests/basic_api.c
> > index 834d8705ff8a..05448a25f1f9 100644
> > --- a/tools/testing/memblock/tests/basic_api.c
> > +++ b/tools/testing/memblock/tests/basic_api.c
> > @@ -303,12 +303,12 @@ static int memblock_add_checks(void)
> >  	return 0;
> >  }
> >  
> > - /*
> > -  * A simple test that marks a memory block of a specified base address
> > -  * and size as reserved and to the collection of reserved memory regions
> > -  * (memblock.reserved). Expect to create a new entry. The region counter
> > -  * and total memory size are updated.
> > -  */
> > +/*
> > + * A simple test that marks a memory block of a specified base address
> > + * and size as reserved and to the collection of reserved memory regions
> > + * (memblock.reserved). Expect to create a new entry. The region counter
> > + * and total memory size are updated.
> > + */
> >  static int memblock_reserve_simple_check(void)
> >  {
> >  	struct memblock_region *rgn;
> 
> I'd pull this patch to the front, so you don't end up modifying a wrong
> style in patch #2. You could also just squash this patch into patch #2
> and mention it in the patch description.

Let's squash this into patch 2.

> -- 
> Thanks,
> 
> David / dhildenb
> 

-- 
Sincerely yours,
Mike.