linux-kernel - RE: [PATCH v3] arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR02MB81025CD159F1B2158EAE979CF0F49@DM8PR02MB8102.namprd02.prod.outlook.com>
Date:   Thu, 21 Apr 2022 17:40:28 +0000
From:   "Taniya Das (QUIC)" <quic_tdas@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        "Taniya Das (QUIC)" <quic_tdas@...cinc.com>
CC:     Douglas Anderson <dianders@...omium.org>,
        Andy Gross <agross@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Taniya Das <tdas@...eaurora.org>
Subject: RE: [PATCH v3] arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio
 clock controllers



Thanks & Regards,
Taniya Das.

-----Original Message-----
From: Stephen Boyd <swboyd@...omium.org> 
Sent: Saturday, April 16, 2022 1:54 AM
To: bjorn.andersson@...aro.org; Rob Herring <robh+dt@...nel.org>; Taniya Das (QUIC) <quic_tdas@...cinc.com>
Cc: Douglas Anderson <dianders@...omium.org>; Andy Gross <agross@...nel.org>; devicetree@...r.kernel.org; linux-arm-msm@...r.kernel.org; linux-kernel@...r.kernel.org; Taniya Das <tdas@...eaurora.org>
Subject: Re: [PATCH v3] arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers

Quoting Taniya Das (2022-02-01 21:32:07)
> Add the low pass audio clock controller device nodes.
>
> Signed-off-by: Taniya Das <tdas@...eaurora.org>
> ---
>  * Fix unwanted extra spaces in reg property.
>  * Fix lpass_aon node clock phandle <&lpasscc> to <&lpasscore>
>
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 43 
> ++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi 
> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 937c2e0e93eb..0d8a0d9d0f89 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -1744,6 +1746,47 @@
>                         #clock-cells = <1>;
>                 };
>
> +               lpass_audiocc: clock-controller@...0000 {
> +                       compatible = "qcom,sc7280-lpassaudiocc";
> +                       reg = <0 0x03300000 0 0x30000>;
> +                       clocks = <&rpmhcc RPMH_CXO_CLK>,
> +                              <&lpass_aon LPASS_AON_CC_MAIN_RCG_CLK_SRC>;
> +                       clock-names = "bi_tcxo", "lpass_aon_cc_main_rcg_clk_src";
> +                       power-domains = <&lpass_aon LPASS_AON_CC_LPASS_AUDIO_HM_GDSC>;
> +                       #clock-cells = <1>;
> +                       #power-domain-cells = <1>;
> +               };
> +
> +               lpass_aon: clock-controller@...0000 {
> +                       compatible = "qcom,sc7280-lpassaoncc";
> +                       reg = <0 0x03380000 0 0x30000>;

I see that this region overlaps with the third region of lpasscc@...0000 in this file. That means the driver for this clk controller doesn't probe. I don't know what the correct fix is, but it's either remove this node and move the driver contents to lpasscc or remove the region from lpasscc and provide those clks from this node.
[Taniya Das] Sure, I can remove the node which should be the cleaner way.

> +                       clocks = <&rpmhcc RPMH_CXO_CLK>,
> +                              <&rpmhcc RPMH_CXO_CLK_A>,
> +                              <&lpasscore LPASS_CORE_CC_CORE_CLK>;
> +                       clock-names = "bi_tcxo", "bi_tcxo_ao", 
> + "iface";