| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Apr 2022 02:53:36 +0800
From: kernel test robot <lkp@...el.com>
To: David Howells <dhowells@...hat.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org
Subject: [dhowells-fs:rxrpc-ringless 10/21] net/rxrpc/local_object.c:172:24:
warning: format specifies type 'unsigned short' but the argument has type
'int'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-ringless
head: c388a8388ad238ffbe0cd204c3eacaf200055751
commit: 3f63ce6fffedc9a4b84006b79835fda0d51fb12d [10/21] rxrpc: Don't use a ring buffer for call Tx queue
config: hexagon-randconfig-r021-20220421 (https://download.01.org/0day-ci/archive/20220422/202204220213.WUyOhZZg-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5bd87350a5ae429baf8f373cb226a57b62f87280)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?id=3f63ce6fffedc9a4b84006b79835fda0d51fb12d
git remote add dhowells-fs https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git fetch --no-tags dhowells-fs rxrpc-ringless
git checkout 3f63ce6fffedc9a4b84006b79835fda0d51fb12d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/rxrpc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> net/rxrpc/local_object.c:172:24: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
"krxrpctxd/%hu", ntohs(udp_conf.local_udp_port));
~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
%d
include/linux/kthread.h:54:48: note: expanded from macro 'kthread_run'
= kthread_create(threadfn, data, namefmt, ## __VA_ARGS__); \
~~~~~~~ ^~~~~~~~~~~
include/linux/kthread.h:28:66: note: expanded from macro 'kthread_create'
kthread_create_on_node(threadfn, data, NUMA_NO_NODE, namefmt, ##arg)
~~~~~~~ ^~~
include/linux/byteorder/generic.h:142:18: note: expanded from macro 'ntohs'
#define ntohs(x) ___ntohs(x)
^~~~~~~~~~~
include/linux/byteorder/generic.h:137:21: note: expanded from macro '___ntohs'
#define ___ntohs(x) __be16_to_cpu(x)
^~~~~~~~~~~~~~~~
include/uapi/linux/byteorder/little_endian.h:43:26: note: expanded from macro '__be16_to_cpu'
#define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/uapi/linux/swab.h:105:2: note: expanded from macro '__swab16'
(__builtin_constant_p((__u16)(x)) ? \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/rxrpc/local_object.c:246:23: warning: unused variable 'c' [-Wunused-variable]
struct rxrpc_local *c = hlist_entry(cursor, struct rxrpc_local, link);
^
2 warnings generated.
vim +172 net/rxrpc/local_object.c
105
106 /*
107 * create the local socket
108 * - must be called with rxrpc_local_mutex locked
109 */
110 static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
111 {
112 struct udp_tunnel_sock_cfg tuncfg = {NULL};
113 struct sockaddr_rxrpc *srx = &local->srx;
114 struct udp_port_cfg udp_conf = {0};
115 struct task_struct *transmitter;
116 struct sock *usk;
117 int ret;
118
119 _enter("%p{%d,%d}",
120 local, srx->transport_type, srx->transport.family);
121
122 udp_conf.family = srx->transport.family;
123 if (udp_conf.family == AF_INET) {
124 udp_conf.local_ip = srx->transport.sin.sin_addr;
125 udp_conf.local_udp_port = srx->transport.sin.sin_port;
126 #if IS_ENABLED(CONFIG_AF_RXRPC_IPV6)
127 } else {
128 udp_conf.local_ip6 = srx->transport.sin6.sin6_addr;
129 udp_conf.local_udp_port = srx->transport.sin6.sin6_port;
130 #endif
131 }
132 ret = udp_sock_create(net, &udp_conf, &local->socket);
133 if (ret < 0) {
134 _leave(" = %d [socket]", ret);
135 return ret;
136 }
137
138 tuncfg.encap_type = UDP_ENCAP_RXRPC;
139 tuncfg.encap_rcv = rxrpc_input_packet;
140 tuncfg.sk_user_data = local;
141 setup_udp_tunnel_sock(net, local->socket, &tuncfg);
142
143 /* set the socket up */
144 usk = local->socket->sk;
145 usk->sk_error_report = rxrpc_error_report;
146
147 switch (srx->transport.family) {
148 case AF_INET6:
149 /* we want to receive ICMPv6 errors */
150 ip6_sock_set_recverr(usk);
151
152 /* Fall through and set IPv4 options too otherwise we don't get
153 * errors from IPv4 packets sent through the IPv6 socket.
154 */
155 fallthrough;
156 case AF_INET:
157 /* we want to receive ICMP errors */
158 ip_sock_set_recverr(usk);
159
160 /* we want to set the don't fragment bit */
161 ip_sock_set_mtu_discover(usk, IP_PMTUDISC_DO);
162
163 /* We want receive timestamps. */
164 sock_enable_timestamps(usk);
165 break;
166
167 default:
168 BUG();
169 }
170
171 transmitter = kthread_run(rxrpc_transmitter, local,
> 172 "krxrpctxd/%hu", ntohs(udp_conf.local_udp_port));
173 if (IS_ERR(transmitter)) {
174 ret = PTR_ERR(transmitter);
175 goto error_sock;
176 }
177
178 local->transmitter = transmitter;
179 _leave(" = 0");
180 return 0;
181
182 error_sock:
183 kernel_sock_shutdown(local->socket, SHUT_RDWR);
184 local->socket->sk->sk_user_data = NULL;
185 sock_release(local->socket);
186 local->socket = NULL;
187 return ret;
188 }
189
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists