linux-kernel - Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ff87bc9-2061-d0c-8cdf-13266a6b1343@panix.com>
Date:   Thu, 21 Apr 2022 14:21:38 -0700 (PDT)
From:   "Kenneth R. Crudup" <kenny@...ix.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
cc:     Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Vidya Sagar <vidyas@...dia.com>, bhelgaas@...gle.com,
        lorenzo.pieralisi@....com, hkallweit1@...il.com,
        wangxiongfeng2@...wei.com, mika.westerberg@...ux.intel.com,
        chris.packham@...iedtelesis.co.nz, yangyicong@...ilicon.com,
        treding@...dia.com, jonathanh@...dia.com, abhsahu@...dia.com,
        sagupta@...dia.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, kthota@...dia.com,
        mmaddireddy@...dia.com, sagar.tv@...il.com,
        Ricky Wu <ricky_wu@...ltek.com>,
        Rajat Jain <rajatja@...gle.com>,
        Prasad Malisetty <quic_pmaliset@...cinc.com>,
        Victor Ding <victording@...gle.com>,
        "Kenneth R. Crudup" <kenny@...ix.com>
Subject: Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for
 suspend/resume


On Thu, 21 Apr 2022, Bjorn Helgaas wrote:

> Vidya's original patch [1] is not upstream, at least AFAIK.  Well, it
> *was* merged as 4257f7e008ea [2] in v5.11-rc1, but then reverted by
> 40fb68c7725a [3] in v5.11-rc7.

Ah, you're absolutely right- now that I think of it, you guys had me cherry-
pick the commit and IIRC it didn't fail when I'd done so:

----
Date: Sat, 5 Feb 2022 09:30:07 -0800 (PST)
From: Kenneth R. Crudup <kenny@...ix.com>
To: Vidya Sagar <vidyas@...dia.com>
Message-ID: <12fe557f-7336-1970-d8f0-5a93529cf8c1@...ix.com>
...

I just reapplied it on top of Linus' master and not only did it go in cleanly(!),
NOW I'm not getting any issues after a suspend/resume. I've attached the output
of "lspci -vvvvnn" before a hibernation (but not the very *first* one; if you
need that output, let me know) and will submit the same post-hibernation (which
is the same as the pre-hibernation case) and the post-suspend case (which is
slightly different) in subsequent E-mails (due to attachment size).
----

	-Kenny

-- 
Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA