linux-kernel - Re: [PATCH] staging: r8188eu: use in-kernel ieee channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YmHsannu/vcKX9Kk@ArchDesktop>
Date:   Fri, 22 Apr 2022 07:44:42 +0800
From:   Solomon Tan <wjsota@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk
Subject: Re: [PATCH] staging: r8188eu: use in-kernel ieee channel

On Thu, Apr 21, 2022 at 08:00:10PM +0300, Dan Carpenter wrote:
> On Thu, Apr 21, 2022 at 09:58:12AM +0800, Solomon Tan wrote:
> > The rtw_ieee80211_channel structure just duplicates the in-kernel
> > ieee80211_channel structure
> 
> When you say that they are duplicates, I expected them to be the same
> but they're not at all.  ieee80211_channel has a bunch more struct
> members.
> 
> I don't really have a problem with the change necessarily but the commit
> message should not have mislead me.

Sorry about that. I will amend the commit message and send it as v2.
Thank you for the review.

> 
> regards,
> dan carpenter
> 

Cheers,
Solomon