linux-kernel - RE: [PATCH V4 00/31] x86/sgx and selftests/sgx: Support SGX2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR11MB559180D1BA05B0E77D354467F6F49@DM8PR11MB5591.namprd11.prod.outlook.com>
Date:   Thu, 21 Apr 2022 23:46:57 +0000
From:   "Dhanraj, Vijay" <vijay.dhanraj@...el.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "bp@...en8.de" <bp@...en8.de>,
        "Lutomirski, Andy" <luto@...nel.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "Shanahan, Mark" <mark.shanahan@...el.com>
CC:     "Christopherson,, Sean" <seanjc@...gle.com>,
        "Huang, Kai" <kai.huang@...el.com>,
        "Zhang, Cathy" <cathy.zhang@...el.com>,
        "Xing, Cedric" <cedric.xing@...el.com>,
        "Huang, Haitao" <haitao.huang@...el.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V4 00/31] x86/sgx and selftests/sgx: Support SGX2

Hi All,

I evaluated V4 patch changes with Gramine and ran into an issue when trying to set EPC page permission to PROT_NONE. It looks like with V3 patch series a change was introduced which requires kernel to have at least R permission when calling RESTRICT IOCTL. This change was done under the assumption that EPCM requires at least R permission for EMODPE/EACCEPT to succeed. But when testing with V2 version, EACCEPT worked fine with page permission set to PROT_NONE. 

Thanks to @Shanahan, Mark for confirming that EPCM does not need to have R value to allow EACCEPT or EMODPE. Given this, can we please revert this change?

Thanks,
-Vijay

> -----Original Message-----
> From: Jarkko Sakkinen <jarkko@...nel.org>
> Sent: Sunday, April 17, 2022 7:58 AM
> To: Dhanraj, Vijay <vijay.dhanraj@...el.com>; Chatre, Reinette
> <reinette.chatre@...el.com>; dave.hansen@...ux.intel.com;
> tglx@...utronix.de; bp@...en8.de; Lutomirski, Andy <luto@...nel.org>;
> mingo@...hat.com; linux-sgx@...r.kernel.org; x86@...nel.org;
> shuah@...nel.org; linux-kselftest@...r.kernel.org
> Cc: Christopherson,, Sean <seanjc@...gle.com>; Huang, Kai
> <kai.huang@...el.com>; Zhang, Cathy <cathy.zhang@...el.com>; Xing,
> Cedric <cedric.xing@...el.com>; Huang, Haitao <haitao.huang@...el.com>;
> Shanahan, Mark <mark.shanahan@...el.com>; hpa@...or.com; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH V4 00/31] x86/sgx and selftests/sgx: Support SGX2
> 
> On Thu, 2022-04-14 at 18:35 +0000, Dhanraj, Vijay wrote:
> > Hi Jarkko,
> >
> > I am working on enabling Gramine with this EDMM patch series. I had
> > tested with V2 patch series and it looked fine. Will evaluate Gramine with
> V4 patch series and post my updates in a couple of days.
> 
> OK, good to hear. Looking forward to it.
> 
> BR, Jarkko