linux-kernel - Re: linux-next: build warning after merge of the block tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220421154306.397748ac@canb.auug.org.au>
Date:   Thu, 21 Apr 2022 15:43:06 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the block tree

Hi all,

On Thu, 21 Apr 2022 12:02:03 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> fs/io_uring.c: In function '__io_sqe_files_unregister':
> fs/io_uring.c:8992:13: warning: unused variable 'i' [-Wunused-variable]
>  8992 |         int i;
>       |             ^
> 
> Introduced by commit
> 
>   16b217ed7bb3 ("io_uring: store SCM state in io_fixed_file->file_ptr")

This become a build failure for i386 defconfig, so I added the
following patch.

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Thu, 21 Apr 2022 15:34:32 +1000
Subject: [PATCH] fix up for "io_uring: store SCM state in
 io_fixed_file->file_ptr"

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 fs/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 1f6004ba0463..9ace35873810 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -8989,9 +8989,9 @@ static void io_free_file_tables(struct io_file_table *table)
 
 static void __io_sqe_files_unregister(struct io_ring_ctx *ctx)
 {
+#if !defined(IO_URING_SCM_ALL)
 	int i;
 
-#if !defined(IO_URING_SCM_ALL)
 	for (i = 0; i < ctx->nr_user_files; i++) {
 		struct file *file = io_file_from_index(ctx, i);
 
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped