linux-kernel - Re: [PATCH v4 4/8] firmware_loader: Add firmware-upload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 21 Apr 2022 14:32:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Russ Weight <russell.h.weight@...el.com>, mcgrof@...nel.org,
        rafael@...nel.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, trix@...hat.com, lgoncalv@...hat.com,
        yilun.xu@...el.com, hao.wu@...el.com,
        matthew.gerlach@...ux.intel.com,
        basheer.ahmed.muddebihal@...el.com, tianfei.zhang@...el.com,
        Russ Weight <russell.h.weight@...el.com>
Subject: Re: [PATCH v4 4/8] firmware_loader: Add firmware-upload support

Hi Russ,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on shuah-kselftest/next mcgrof/sysctl-next linus/master v5.18-rc3 next-20220419]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Russ-Weight/Extend-FW-framework-for-user-FW-uploads/20220420-071906
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 3123109284176b1532874591f7c81f3837bbdc17
config: parisc-buildonly-randconfig-r006-20220420 (https://download.01.org/0day-ci/archive/20220420/202204201956.1mdJkUkr-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/9280379c623309746315a540c66b7bbcc980b32e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Russ-Weight/Extend-FW-framework-for-user-FW-uploads/20220420-071906
        git checkout 9280379c623309746315a540c66b7bbcc980b32e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/base/ drivers/scsi/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/base/firmware_loader/sysfs.c:113:5: error: redefinition of 'register_sysfs_loader'
     113 | int register_sysfs_loader(void)
         |     ^~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/base/firmware_loader/sysfs.c:9:
   drivers/base/firmware_loader/sysfs.h:64:19: note: previous definition of 'register_sysfs_loader' with type 'int(void)'
      64 | static inline int register_sysfs_loader(void)
         |                   ^~~~~~~~~~~~~~~~~~~~~
   drivers/base/firmware_loader/sysfs.c: In function 'register_sysfs_loader':
>> drivers/base/firmware_loader/sysfs.c:119:16: error: implicit declaration of function 'register_firmware_config_sysctl' [-Werror=implicit-function-declaration]
     119 |         return register_firmware_config_sysctl();
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/firmware_loader/sysfs.c: At top level:
>> drivers/base/firmware_loader/sysfs.c:122:6: error: redefinition of 'unregister_sysfs_loader'
     122 | void unregister_sysfs_loader(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/base/firmware_loader/sysfs.c:9:
   drivers/base/firmware_loader/sysfs.h:69:20: note: previous definition of 'unregister_sysfs_loader' with type 'void(void)'
      69 | static inline void unregister_sysfs_loader(void)
         |                    ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/firmware_loader/sysfs.c: In function 'unregister_sysfs_loader':
>> drivers/base/firmware_loader/sysfs.c:124:9: error: implicit declaration of function 'unregister_firmware_config_sysctl' [-Werror=implicit-function-declaration]
     124 |         unregister_firmware_config_sysctl();
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/register_sysfs_loader +113 drivers/base/firmware_loader/sysfs.c

cafe6fbc6b8a99 Russ Weight 2022-04-19  112  
cafe6fbc6b8a99 Russ Weight 2022-04-19 @113  int register_sysfs_loader(void)
cafe6fbc6b8a99 Russ Weight 2022-04-19  114  {
cafe6fbc6b8a99 Russ Weight 2022-04-19  115  	int ret = class_register(&firmware_class);
cafe6fbc6b8a99 Russ Weight 2022-04-19  116  
cafe6fbc6b8a99 Russ Weight 2022-04-19  117  	if (ret != 0)
cafe6fbc6b8a99 Russ Weight 2022-04-19  118  		return ret;
cafe6fbc6b8a99 Russ Weight 2022-04-19 @119  	return register_firmware_config_sysctl();
cafe6fbc6b8a99 Russ Weight 2022-04-19  120  }
cafe6fbc6b8a99 Russ Weight 2022-04-19  121  
cafe6fbc6b8a99 Russ Weight 2022-04-19 @122  void unregister_sysfs_loader(void)
cafe6fbc6b8a99 Russ Weight 2022-04-19  123  {
cafe6fbc6b8a99 Russ Weight 2022-04-19 @124  	unregister_firmware_config_sysctl();
cafe6fbc6b8a99 Russ Weight 2022-04-19  125  	class_unregister(&firmware_class);
cafe6fbc6b8a99 Russ Weight 2022-04-19  126  }
cafe6fbc6b8a99 Russ Weight 2022-04-19  127  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp