linux-kernel - Re: [PATCH] HID: amd_sfh: change global variables to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2204211019190.30217@cbobk.fhfr.pm>
Date:   Thu, 21 Apr 2022 10:19:26 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Tom Rix <trix@...hat.com>
cc:     basavaraj.natikar@....com, benjamin.tissoires@...hat.com,
        nehal-bakulchandra.shah@....com, Shyam-sundar.S-k@....com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: amd_sfh: change global variables to static

On Wed, 20 Apr 2022, Tom Rix wrote:

> Smatch reports this representative issue
> amd_sfh_hid_report_desc.h:182:10: warning: symbol 'gyro3_report_descriptor' was not declared. Should it be static?
> Similar issues for comp3_report_descriptor and als_report_descriptor.
> 
> Global variables should not be defined in header files.
> This only works because amd_sfh_hid_report_desc.h in only included by
> amd_sfh_hid_desc.c so change the storage-class specifiers to static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied, thanks Tom.

-- 
Jiri Kosina
SUSE Labs