lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Apr 2022 09:33:45 +0100 From: Will Deacon <will@...nel.org> To: Robin Murphy <robin.murphy@....com> Cc: joro@...tes.org, iommu@...ts.linux-foundation.org, sven@...npeter.dev, robdclark@...il.com, m.szyprowski@...sung.com, baolu.lu@...ux.intel.com, yong.wu@...iatek.com, mjrosato@...ux.ibm.com, gerald.schaefer@...ux.ibm.com, zhang.lyra@...il.com, thierry.reding@...il.com, vdumpa@...dia.com, jean-philippe@...aro.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 04/13] iommu/arm-smmu: Clean up bus_set_iommu() On Wed, Apr 20, 2022 at 05:05:03PM +0100, Robin Murphy wrote: > On 2022-04-19 15:40, Will Deacon wrote: > > On Thu, Apr 14, 2022 at 01:42:33PM +0100, Robin Murphy wrote: > > > Stop calling bus_set_iommu() since it's now unnecessary. With device > > > probes now replayed for every IOMMU instance registration, the whole > > > sorry ordering workaround for legacy DT bindings goes too, hooray! > > > > Ha, I hope you tested this! > > Oh alright then, since it's you... :) > > I've hacked up a Juno DT with the old bindings, and (after needing a while > to remember that they're fundamentally incompatible with disable_bypass), > can confirm that with my whole dev branch including this series applied, it > boots and creates IOMMU groups as expected. I then made the mistake of > trying without the branch to check whether the squawks from > iommu_setup_dma_ops() were new or not, and... well... plain rc3 doesn't even > boot on the same setup - it's somehow blowing up in the failure cleanup path > of iommu_bus_init(), apparently calling iommu_release_device() on something > where dev->iommu->iommu_dev is NULL, for reasons that are far from clear and > I'm not sure I can really be bothered to debug further... :/ Great, so your series is a fix! Will
Powered by blists - more mailing lists