linux-kernel - Re: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmEYvYA0uXatStZg@kuha.fi.intel.com>
Date:   Thu, 21 Apr 2022 11:41:33 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Mathias Nyman <mathias.nyman@...ux.intel.com>,
        "Sandeep Maheswaram (Temp) (QUIC)" <quic_c_sanm@...cinc.com>,
        Felipe Balbi <balbi@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Doug Anderson <dianders@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Pavan Kumar Kondeti (QUIC)" <quic_pkondeti@...cinc.com>,
        "Pratham Pratap (QUIC)" <quic_ppratap@...cinc.com>,
        "Krishna Kurapati PSSNV (QUIC)" <quic_kriskura@...cinc.com>,
        "Vidya Sagar Pulyala (Temp) (QUIC)" <quic_vpulyala@...cinc.com>
Subject: Re: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers

On Thu, Apr 21, 2022 at 10:36:57AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 21, 2022 at 10:46:37AM +0300, Heikki Krogerus wrote:
> > On Wed, Apr 20, 2022 at 04:20:52PM +0300, Mathias Nyman wrote:
> > > On 19.4.2022 13.17, Sandeep Maheswaram (Temp) (QUIC) wrote:
> > > > Hi Mathias, Felipe,
> > > > 
> > > >> -----Original Message-----
> > > >> From: Sandeep Maheswaram (Temp) (QUIC) <quic_c_sanm@...cinc.com>
> > > >> Sent: Thursday, April 7, 2022 3:01 PM
> > > >> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Felipe Balbi
> > > >> <balbi@...nel.org>; Stephen Boyd <swboyd@...omium.org>; Doug
> > > >> Anderson <dianders@...omium.org>; Matthias Kaehlcke
> > > >> <mka@...omium.org>; Mathias Nyman <mathias.nyman@...el.com>
> > > >> Cc: linux-arm-msm@...r.kernel.org; linux-usb@...r.kernel.org; linux-
> > > >> kernel@...r.kernel.org; Pavan Kumar Kondeti (QUIC)
> > > >> <quic_pkondeti@...cinc.com>; Pratham Pratap (QUIC)
> > > >> <quic_ppratap@...cinc.com>; Krishna Kurapati PSSNV (QUIC)
> > > >> <quic_kriskura@...cinc.com>; Vidya Sagar Pulyala (Temp) (QUIC)
> > > >> <quic_vpulyala@...cinc.com>; Sandeep Maheswaram (Temp) (QUIC)
> > > >> <quic_c_sanm@...cinc.com>
> > > >> Subject: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
> > > >>
> > > >> Runtime suspend of phy drivers was failing from DWC3 driver as runtime
> > > >> usage value is 2 because the phy is initialized from
> > > >> DWC3 core and HCD core.
> > > >> Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
> > > >> This property can be set to avoid phy initialization in HCD core.
> > > >>
> > > >> v3:
> > > >> Coming back to this series based on discussion at below thread
> > > >> https://patchwork.kernel.org/project/linux-arm-msm/patch/1648103831-
> > > >> 12347-4-git-send-email-quic_c_sanm@...cinc.com/
> > > >> Dropped the dt bindings PATCH 1/3 in v2
> > > >> https://patchwork.kernel.org/project/linux-arm-msm/cover/1636353710-
> > > >> 25582-1-git-send-email-quic_c_sanm@...cinc.com/
> > > >>
> > > >> v2:
> > > >> Updated the commit descriptions.
> > > >> Changed subject prefix from dwc to dwc3.
> > > >> Increased props array size.
> > > >>
> > > >> Sandeep Maheswaram (2):
> > > >>   usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT
> > > >>     quirk
> > > >>   usb: dwc3: host: Set the property usb-skip-phy-init
> > > >>
> > > >>  drivers/usb/dwc3/host.c      | 4 +++-
> > > >>  drivers/usb/host/xhci-plat.c | 3 +++
> > > >>  2 files changed, 6 insertions(+), 1 deletion(-)
> > > >>
> > > >> --
> > > >> 2.7.4
> > > > 
> > > > Please let me know your opinion about this series.
> > > 
> > > Otherwise looks good but wondering if we should document that new device
> > > property somewhere. 
> > > 
> > > Couldn't find a standard way how those device properties excluded from
> > > Documentation/devicetree/binding are documented
> > 
> > Couldn't it be just documented in drivers/usb/host/xhci-plat.c for now?
> 
> That's not where DT properties are documented.

It's not a DT property.

-- 
heikki