linux-kernel - Re: [Bug 215867] New: tboot suspend broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmEjGl2RzYARUHK2@zn.tnic>
Date:   Thu, 21 Apr 2022 11:25:46 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     bugzilla-daemon@...nel.org, kernel@...ney.com,
        Vincent Donnefort <vincent.donnefort@....com>
Cc:     x86-ml <x86@...nel.org>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [Bug 215867] New: tboot suspend broken

Switching to mail because I can't CC the patch author on bugzilla.

Vincent, see below. It points to your commit:

453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")

@Derek, just to make sure: you're seeing this with the latest 5.17
kernel too, correct?

Thx.

On Thu, Apr 21, 2022 at 02:07:42AM +0000, bugzilla-daemon@...nel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=215867
> 
>             Bug ID: 215867
>            Summary: tboot suspend broken
>            Product: Platform Specific/Hardware
>            Version: 2.5
>     Kernel Version: 5.12.0
>           Hardware: All
>                 OS: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: x86-64
>           Assignee: platform_x86_64@...nel-bugs.osdl.org
>           Reporter: kernel@...ney.com
>         Regression: Yes
> 
> I am using tboot (v1.10.5) to make use of intel-txt and all was working fine
> with the Linux kernel 5.10 series. However later in 5.12 release candidates, I
> have  proper booting however suspend is broken. I am using a Lenovo T460p.
> Usually when suspending on this machine the power button LED will blink 8 times
> and then it goes into a sleep state. With newer kernels I get power LED and
> caps lock LED blinking, cpu fan runs fast, and can't get out of that state
> without hard powerdown.
> 
> I did a git bisect on and found that commit
> 453e41085183980087f8a80dada523caf1131c3c is the one that breaks tboot+suspend
> to ram. It is part of a series of some cpu hotplug commits.
> 
> Just to be clear: if I build a kernel from the commit just before this one, I
> can suspend and resume, but if I build with this commit I can not suspend,
> laptop gets stuck on blinking power LED. Let me also mention that, given the
> above commit, if I do not use tboot, I can suspend and resume ok. It is only
> within the tboot boot context that I have suspend&resume problems.
> 
> -- 
> You may reply to this email to add a comment.
> 
> You are receiving this mail because:
> You are watching the assignee of the bug.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette