linux-kernel - Re: [PATCH v3] drm/gma500: depend on framebuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMeQTsbh-Fy4CORBTX=AfZ+K-fZYUQ=hY=ctLFyu9KcJ5NgFUA@mail.gmail.com>
Date:   Thu, 21 Apr 2022 14:39:08 +0200
From:   Patrik Jakobsson <patrik.r.jakobsson@...il.com>
To:     Thomas Zimmermann <tzimmermann@...e.de>
Cc:     James Hilliard <james.hilliard1@...il.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer

On Thu, Apr 21, 2022 at 1:49 PM Thomas Zimmermann <tzimmermann@...e.de> wrote:
>
> Hi
>
> Am 09.04.22 um 06:23 schrieb James Hilliard:
> > Select the efi framebuffer if efi is enabled.
> >
> > This appears to be needed for video output to function correctly.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@...il.com>
> > ---
> > Changes v2 -> v3:
> >    - select EFI_FB instead of depending on it
> > Changes v1 -> v2:
> >    - use depends instead of select
> > ---
> >   drivers/gpu/drm/gma500/Kconfig | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
> > index 0cff20265f97..a422fa84d53b 100644
> > --- a/drivers/gpu/drm/gma500/Kconfig
> > +++ b/drivers/gpu/drm/gma500/Kconfig
> > @@ -2,11 +2,13 @@
> >   config DRM_GMA500
> >       tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
> >       depends on DRM && PCI && X86 && MMU
> > +     depends on FB
>
> Why do we need FB here? Framebuffer support should be hidden by DRM's
> fbdev helpers.

It is not needed but gives him video output since it enables the drm
fbdev emulation.

I looked some more at the logs and it seems weston doesn't work on his
system without the fbdev backend. So the question is why weston isn't
working without fbdev? Perhaps this is just a Weston configuration
issue?