lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Apr 2022 15:17:39 +0100 From: David Howells <dhowells@...hat.com> To: Jeffle Xu <jefflexu@...ux.alibaba.com> Cc: dhowells@...hat.com, linux-cachefs@...hat.com, xiang@...nel.org, chao@...nel.org, linux-erofs@...ts.ozlabs.org, torvalds@...ux-foundation.org, gregkh@...uxfoundation.org, willy@...radead.org, linux-fsdevel@...r.kernel.org, joseph.qi@...ux.alibaba.com, bo.liu@...ux.alibaba.com, tao.peng@...ux.alibaba.com, gerry@...ux.alibaba.com, eguan@...ux.alibaba.com, linux-kernel@...r.kernel.org, luodaowen.backend@...edance.com, tianzichen@...ishou.com, fannaihao@...du.com, zhangjiachen.jaycee@...edance.com Subject: Re: [PATCH v9 06/21] cachefiles: enable on-demand read mode Jeffle Xu <jefflexu@...ux.alibaba.com> wrote: > + if (IS_ENABLED(CONFIG_CACHEFILES_ONDEMAND) && > + !strcmp(args, "ondemand")) { > + set_bit(CACHEFILES_ONDEMAND_MODE, &cache->flags); > + } else if (*args) { > + pr_err("'bind' command doesn't take an argument\n"); The error message isn't true if CONFIG_CACHEFILES_ONDEMAND=y. It would be better to say "Invalid argument to the 'bind' command". > -retry: > /* If the caller asked us to seek for data before doing the read, then > * we should do that now. If we find a gap, we fill it with zeros. > */ > @@ -120,16 +119,6 @@ static int cachefiles_read(struct netfs_cache_resources *cres, > if (read_hole == NETFS_READ_HOLE_FAIL) > goto presubmission_error; > > - if (read_hole == NETFS_READ_HOLE_ONDEMAND) { > - ret = cachefiles_ondemand_read(object, off, len); > - if (ret) > - goto presubmission_error; > - > - /* fail the read if no progress achieved */ > - read_hole = NETFS_READ_HOLE_FAIL; > - goto retry; > - } > - Unexplained deletion of newly added code. David
Powered by blists - more mailing lists