linux-kernel - Re: [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Apr 2022 19:51:02 -0700
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.

On Fri, Apr 22, 2022 at 10:00:54AM +1000, Stephen Rothwell wrote:
> I assume that there is some good reason that topology_ppin() is not
> implemented as a static inline function?

I don't think so. I just cut & pasted how all the other topology_*()
things were implemented.

Making it a static inline appears to fix this problem. But before
embarrassing myself with a third broken version I'll let zero day
crunch on:

  git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git hide_ppin

to see if there is some subtle config or arch where the inline trick
doesn't work.

Thanks for the idea! :-)

-Tony