linux-kernel - Re: [PATCH] staging: vchiq_arm: change vchiq_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Apr 2022 08:32:35 -0700
From:   Tom Rix <trix@...hat.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     nsaenz@...nel.org, bcm-kernel-feedback-list@...adcom.com,
        gregkh@...uxfoundation.org, stefan.wahren@...e.com,
        gascoar@...il.com, ojaswin98@...il.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vchiq_arm: change vchiq_platform_init from
 global to static


On 4/22/22 7:44 AM, Dan Carpenter wrote:
> On Mon, Apr 18, 2022 at 12:43:56PM -0400, Tom Rix wrote:
>> Smatch reports this issue
>> vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init'
>>    was not declared. Should it be static?
> This is a Sparse warning, not Smatch.

Yes, this is correct.

Though I am using

make CC=cgcc

And forgot which one I had installed last.

Tom

>
> Use this command for Smatch
> ~/smatch/smatch_scripts/kchecker drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>
> And this command for Sparse
> ~/smatch/smatch_scripts/kchecker --sparse drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>
> regards,
> dan carpenter
>